Add companion beast and attack controls to the Skills tab#2165
Open
ltogniolli wants to merge 3 commits into
Open
Add companion beast and attack controls to the Skills tab#2165ltogniolli wants to merge 3 commits into
ltogniolli wants to merge 3 commits into
Conversation
Rare tamed beasts carry randomly rolled monster modifiers, returned by the character API as "tamedBeastProperties". These were previously discarded on import, so companions were modeled only as their base monster. - Import: parse tamedBeastProperties into a per-gem modifier list, resolving mod ids from "[ModId |Display]" tokens with a display-line fallback for nameplate-only lines; user enable/disable choices survive re-import - Data: new generated Data/TamedBeastMods.lua (export script iterates the Monster-domain mod pool, naming entries from KeywordPopups/ArchnemesisMods and resolving effects through SkillStatMap); mods with a positive spawn weight are flagged rollable and offered in the UI - Calcs: enabled modifiers apply to the companion minion's modDB, gated on the active skill being a Companion so stale lists never leak - UI: "Beast Modifiers" section in the socket group editor with per-row selection dropdown, enable checkbox, remove button and calc-comparison tooltips, mirroring the gem slot layout - Persistence: modifiers saved as TamedBeastMod child elements of Gem; old builds are unaffected
Tamed beasts roll "Monster*" mods in the wild, but the itemised companion carries the standalone "PlayerMonster*" twin, which is what the character API reports. The exporter now enumerates ArchnemesisMods and emits only Player mods whose beast-side twin is a rollable prefix/suffix, resolving display text through the twin and replacing the rollable flag with the twin's spawn weight table. Mods whose spawn weights can never roll on the selected beast's tags (e.g. Haste Aura has fast_movement = 0) are ignored by calcs and flagged in red on the skill panel and the selection tooltip. Spectres.lua picks up "boss" monster tags for boss beasts so boss-gated mods (spawn weight boss = 0) validate correctly; the exporter change producing them ships separately.
The socket group panel for Companion gems gains a beast selector and the list of the beast's attacks. Each attack can be included in Full DPS as its own entry, instead of only the active attack counting: checking an attack pulls the group into Full DPS, unchecking the last one removes it, and enabling Include in Full DPS selects the first attack. The selection is stored per gem by skill id, so it survives beast swaps and falls back to the active attack when nothing matches. Full DPS minion entries now lead with the attack name and show the owning skill as their source line, like the best-ailment entries. Hovering an attack shows its skill data in the player gem tooltip style: tag line, cost, cooldown with stored uses, attack speed, time and damage, crit chance, description, and stat description lines coloured by calc support. Labels gain opt-in tooltip hosting for this; unconfigured labels stay mouse-transparent. Changing the beast renames the Companion gem and refreshes the gem slot display, from both the Skills tab and the sidebar dropdowns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon PR#2147
Adds supports for a beast selector for companions in the skill panel, lists beasts attacks, with rich tooltips, and allows each one to be selected for Full DPS calculations independently, and tweaks the display format of minion damage on the full dps report.
After screenshot: