Add socket position view to trader#2194
Open
vaisest wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds the same socket view that the item tab has on the socket controls to the trader tool, which helps with actually searching for the correct jewel position. Especially useful for radius jewels.
The border size in both places was set to 1 px. The view was also made a little less square, and widened by 8 pixels to make it the same size as the dropdown (yes, it's important)
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/vqrRJJWMme4D
Before screenshot:
After screenshot: