Skip to content

Update fs.expose.ftp for compatibility with latest pyftpdlib.#217

Closed
travcunn wants to merge 25 commits into
PyFilesystem:masterfrom
smartfile:master
Closed

Update fs.expose.ftp for compatibility with latest pyftpdlib.#217
travcunn wants to merge 25 commits into
PyFilesystem:masterfrom
smartfile:master

Conversation

@travcunn

@travcunn travcunn commented Oct 7, 2015

Copy link
Copy Markdown

The pyftpdlib project has moved some imports that will be problematic when a new release is created. This should be merged as soon as pyftpdlib creates a new release (newer than 1.4).

@willmcgugan

Copy link
Copy Markdown
Member

I guess I should pin pyfilesystem to pyftpdlib 1.4?

@lurch

lurch commented Jan 7, 2016

Copy link
Copy Markdown
Contributor

@travcunn Could you please rework this PR so that it only contains commit 08bac4b and not the unrelated commits?
(Easiest method might be to close this PR, create a new branch, recreate your fixes there, and submit a PR from that branch?)

@kitsmag

kitsmag commented Jan 7, 2016

Copy link
Copy Markdown

A git rebase plus git push -f might work, too

@kitsmag

kitsmag commented Jan 8, 2016

Copy link
Copy Markdown

I took the liberty of re-requesting #217 without the unrelated parts as #239 (also, I put this account to rest and use my private one, @zommuter)

@lurch

lurch commented Aug 1, 2016

Copy link
Copy Markdown
Contributor

Closing in favour of #243

@lurch lurch closed this Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants