Skip to content

Fix the button layout on receive#539

Merged
n13 merged 1 commit into
mainfrom
fix_receive_screen
Jun 23, 2026
Merged

Fix the button layout on receive#539
n13 merged 1 commit into
mainfrom
fix_receive_screen

Conversation

@n13

@n13 n13 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Adds the copy button back - it was flipped vs the design, which made me complain about it to the designer

All buttons tested ✅

Screens

Simulator Screenshot - iPhone 17e - 2026-06-23 at 16 11 48 Simulator Screenshot - iPhone 17e - 2026-06-23 at 16 12 01

Design

image

Adds the copy button back - it was flipped vs the design, which made me complain about it to the designer
@n13

n13 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Review — Verdict: Approve / LGTM

Focused, low-risk UI fix. The core change in receive_screen.dart swaps the bottom-bar content between the two tabs, and this is correct:

  • QR tab has no inline copy affordance (just the QR + checksum + address text), so it correctly gets the Copy + Share button row.
  • Address tab renders AddressDetailsCard, which already has its own inline per-field copy buttons (address + checkphrase). So the previous Copy button there was redundant; reducing it to a single Share button is right and matches the design.

Other changes

  • _copyAccountDetails_copyAddress now copies just the address (_accountId) instead of the multi-line Account Id … Checkphrase … blob, with the toast updated to "Address copied to clipboard". Consistent with the rename and a cleaner UX — the checkphrase is still reachable via the QR-tab text and the address card's own copy button.
  • Removed the now-unused receiveClipboardContent key from app_en.arb / app_id.arb and the generated app_localizations*.dart. Verified there are no remaining references anywhere in the codebase, and both locale files (the only two: en, id) are updated consistently. The hand-edited generated files match what flutter gen-l10n would produce.

Notes / nits (non-blocking)

  • The _accountId! force-unwrap in _copyAddress is safe: the bottom content (and thus the Copy button) is only built when !isLoading, which guarantees _accountId != null.
  • No unused imports introduced; _checksum is still used by _share, QrCodeTab, and AddressTab.

CI

Analyze check is still pending at review time — worth a green tick before merge, but nothing in the diff looks likely to fail it.

Nice cleanup. 👍

@dewabisma dewabisma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@n13 n13 merged commit bb0cc97 into main Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants