feat!: update the default renderer to thrasos#9976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
thrasosfromgerasReason for Changes
geras is the old style, thrasos has been our recommended renderer for a while now. each block has 1/3 fewer dom elements associated with it, so it should be more performant as well.
Test Coverage
updated
Documentation
updated
BREAKING CHANGES
This change only affects you if you intended to use the
gerasrenderer but did not specify it explicitly in the options. We recommend that you use the thrasos renderer in this case. See the screenshots for comparisons; the changes are subtle enough that you do not necessarily have to update any of your visual resources. Because there are fewer dom elements, you may see increased performance on large workspaces.If you wish to continue using the
gerasrenderer, you need only specify the option when you inject Blockly.above: thrasos (new default)
above: geras (old default)