fix: dont crash after reverting move#9980
Open
maribethb wants to merge 1 commit into
Open
Conversation
mikeharv
approved these changes
Jun 11, 2026
Collaborator
|
This has one negative side-effect. Start a move on a top-level block, then cancel it with Esc. The block gets a fixed yellow (slightly muted?) outline and then you can no longer drag it with the mouse. You can fix this by using the keyboard to start and confirm another move. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes
With two connected blocks on the workspace, move one to a different connection and commit the move.
Start moving the same block again, but hit escape before committing.
block_svg.ts:313 Uncaught HierarchyRequestError: Failed to execute 'appendChild' on 'Node': The new child element contains the parent.
at BlockSvg.setParent (block_svg.ts:313:44)3. Hit escape again
Keyboard shortcut named "commitMove" not found.
(anonymous) @ shortcut_registry.ts:80
dom.ts:119 Uncaught RangeError: Maximum call stack size exceeded
at dom.ts:119:24
Proposed Changes
revertDragsince it's handled inendDragReason for Changes
Test Coverage
added test for this
Documentation
Additional Information