Skip to content

Bump bitfields from 1.0.3 to 3.0.0#134

Merged
Sewer56 merged 1 commit into
mainfrom
deps/bitfields-3.0.0
Jun 9, 2026
Merged

Bump bitfields from 1.0.3 to 3.0.0#134
Sewer56 merged 1 commit into
mainfrom
deps/bitfields-3.0.0

Conversation

@Sewer56

@Sewer56 Sewer56 commented Jun 9, 2026

Copy link
Copy Markdown
Member

Migrates the four packed entry structs in reloaded-code-core to the bitfields v3 API and closes the equivalent dependabot PR (#133).

bitfields v3 auto-derives Clone and Copy on the generated type, so the manual #[derive(Clone, Copy, ...)] lines on the four structs were dropped. PartialEq, Eq, and Hash are still added manually to preserve the public API surface (PackedModelEntry is used as an AHashMap key in builder.rs).

Verified locally with bash src/.cargo/verify.sh (build, test, clippy, docs all pass).

Migrate packed entry structs to bitfields v3 API. The macro now
auto-derives Clone and Copy, so manual derives for those conflict.
PartialEq, Eq, and Hash are still added manually to preserve the
public API surface of the affected types.
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Sewer56 Sewer56 merged commit ee3a736 into main Jun 9, 2026
20 of 21 checks passed
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 41899d08-b964-4fde-b9bf-eec7ab381b50

📥 Commits

Reviewing files that changed from the base of the PR and between 52b0a92 and be27518.

⛔ Files ignored due to path filters (1)
  • src/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • src/Cargo.toml
  • src/reloaded-code-core/src/models/catalog/internal/packed_env_range.rs
  • src/reloaded-code-core/src/models/catalog/internal/packed_model_entry.rs
  • src/reloaded-code-core/src/models/catalog/internal/packed_provider_model_table_entry.rs
  • src/reloaded-code-core/src/models/catalog/internal/packed_provider_table_entry.rs

Walkthrough

This PR upgrades the bitfields workspace dependency from version 1.0.3 to 3.0.0 and aligns four packed bitfield struct types to the updated crate. The changes remove Clone and Copy derives from PackedEnvRange, PackedModelEntry, PackedProviderModelTableEntry, and PackedProviderTableEntry while retaining PartialEq, Eq, and Hash traits. No logic, APIs, or packing layouts were modified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: upgrading the bitfields dependency from version 1.0.3 to 3.0.0, which is the primary objective of the PR.
Description check ✅ Passed The description covers the key aspects: migration to bitfields v3 API, explanation of derive trait changes, mention of closing a dependabot PR, and verification steps performed. It exceeds the minimal template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deps/bitfields-3.0.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sewer56 Sewer56 deleted the deps/bitfields-3.0.0 branch June 9, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant