Add Windows 11 on ARM to CI#605
Draft
stefanatwork wants to merge 17 commits into
Draft
Conversation
stefanatwork
changed the title
Agent-Logs-Url: https://github.com/RenderKit/embree/sessions/ead49f65-088a-401f-b6ff-a821bf4b5b25 Co-authored-by: stefanatwork <93931354+stefanatwork@users.noreply.github.com>
Agent-Logs-Url: https://github.com/RenderKit/embree/sessions/71a93d2a-2cfa-4e53-ad36-40765438ddee Co-authored-by: stefanatwork <93931354+stefanatwork@users.noreply.github.com>
Copilot
AI
changed the title
Windows on ARM CI workflow
Add Windows on ARM (ARM64) CI support
May 27, 2026
Copilot
AI
changed the title
Add Windows on ARM (ARM64) CI support
Force Windows ARM CI to use MSVC toolchain
May 27, 2026
Copilot
AI
changed the title
Force Windows ARM CI to use MSVC toolchain
Fix Windows ARM public CI toolchain selection and failure handling
May 27, 2026
Copilot stopped work on behalf of
stefanatwork due to an error
May 27, 2026 15:15
Copilot
AI
changed the title
Fix Windows ARM public CI toolchain selection and failure handling
Set INTERNAL tasking for Windows 11 ARM CI
May 27, 2026
…nversion operators On ARM64 MSVC, the arm_neon.h header from the compiler aliases __m128 and __m128i to the same underlying type (__n128), causing C++ overload ambiguity when both implicit conversion operators are defined. This is a less invasive solution than removing all implicit operators and requiring explicit casts throughout the codebase. Solution: - Create wrapper types (__m128_wrapper, __m128i_wrapper, __m128d_wrapper) for ARM64 MSVC - On other platforms, use identity wrappers that compile away to nothing - Update vector types (vfloat4, vint4, vuint4, vboolf4) to use these wrappers - Implicit conversion operators remain unchanged at call sites - No performance overhead when inlined This approach keeps the implicit operator API intact while disambiguating the underlying types for ARM64 MSVC, requiring changes only to vector type declarations rather than hundreds of call sites throughout the codebase. Files modified: - common/simd/arm/simd_wrapper_types.h (new file) - common/simd/vfloat4_sse2.h - common/simd/vint4_sse2.h - common/simd/vuint4_sse2.h - common/simd/vboolf4_sse2.h Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
stefanatwork
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Windows on ARM support to the public CI runners.