Fix cmake warnings

CMakePresets.json

@@ -0,0 +1,140 @@
+{
+   "configurePresets" : [
+      {
+         "cacheVariables" : {
+            "CMAKE_BUILD_TYPE" : {
+               "type" : "STRING",
+               "value" : "RelWithDebInfo"
+            },
+            "CMAKE_CXX_EXTENSIONS" : {
+               "type" : "BOOL",
+               "value" : "OFF"
+            },
+            "CMAKE_CXX_STANDARD_REQUIRED" : {
+               "type" : "BOOL",
+               "value" : "ON"
+            },
+            "sbncode_ADD_ARCH_DIRS_INIT" : {
+               "type" : "INTERNAL",
+               "value" : "LIBRARY_DIR;BIN_DIR"
+            },
+            "sbncode_ADD_NOARCH_DIRS_INIT" : {
+               "type" : "INTERNAL",
+               "value" : "GDML_DIR;INCLUDE_DIR;FHICL_DIR;FW_DIR"
+            },
+            "sbncode_BIN_DIR_INIT" : {
+               "type" : "STRING",
+               "value" : "bin"
+            },
+            "sbncode_FHICL_DIR_INIT" : {
+               "type" : "STRING",
+               "value" : "fcl"
+            },
+            "sbncode_FW_DIR_INIT" : {
+               "type" : "STRING",
+               "value" : "scripts"
+            },
+            "sbncode_INCLUDE_DIR_INIT" : {
+               "type" : "STRING",
+               "value" : "include"
+            },
+            "sbncode_LIBRARY_DIR_INIT" : {
+               "type" : "STRING",
+               "value" : "lib"
+            }
+         },
+         "description" : "Configuration settings translated from ups/product_deps",
+         "displayName" : "Configuration from product_deps",
+         "hidden" : true,
+         "name" : "from_product_deps"
+      },
+      {
+         "cacheVariables" : {
+            "CMAKE_CXX_COMPILER" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_CXX_COMPILER}"
+            },
+            "CMAKE_CXX_STANDARD" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_CXX_STANDARD}"
+            },
+            "CMAKE_C_COMPILER" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_C_COMPILER}"
+            },
+            "CMAKE_Fortran_COMPILER" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_Fortran_COMPILER}"
+            },
+            "UPS_CXX_COMPILER_ID" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_CXX_COMPILER_ID}"
+            },
+            "UPS_CXX_COMPILER_VERSION" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_CXX_COMPILER_VERSION}"
+            },
+            "UPS_C_COMPILER_ID" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_C_COMPILER_ID}"
+            },
+            "UPS_C_COMPILER_VERSION" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_C_COMPILER_VERSION}"
+            },
+            "UPS_Fortran_COMPILER_ID" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_Fortran_COMPILER_ID}"
+            },
+            "UPS_Fortran_COMPILER_VERSION" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_Fortran_COMPILER_VERSION}"
+            },
+            "WANT_UPS" : {
+               "type" : "BOOL",
+               "value" : true
+            },
+            "sbncode_EXEC_PREFIX_INIT" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_FQ_DIR}"
+            },
+            "sbncode_UPS_BUILD_ONLY_DEPENDENCIES_INIT" : {
+               "type" : "STRING",
+               "value" : "cetmodules"
+            },
+            "sbncode_UPS_PRODUCT_FLAVOR_INIT" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_FLAVOR}"
+            },
+            "sbncode_UPS_PRODUCT_NAME_INIT" : {
+               "type" : "STRING",
+               "value" : "sbncode"
+            },
+            "sbncode_UPS_QUALIFIER_STRING_INIT" : {
+               "type" : "STRING",
+               "value" : "$env{CETPKG_QUALSPEC}"
+            }
+         },
+         "description" : "Extra configuration for UPS package generation",
+         "displayName" : "UPS extra configuration",
+         "hidden" : true,
+         "name" : "extra_for_UPS"
+      },
+      {
+         "description" : "Default configuration including settings from ups/product_deps",
+         "displayName" : "Default configuration",
+         "inherits" : "from_product_deps",
+         "name" : "default"
+      },
+      {
+         "description" : "Default configuration for UPS package generation",
+         "displayName" : "Default configuration for UPS",
+         "inherits" : [
+            "default",
+            "extra_for_UPS"
+         ],
+         "name" : "for_UPS"
+      }
+   ],
+   "version" : 3
+}

sbncode/BeamSpillInfoRetriever/ICARUSBNBEXTRetriever/CMakeLists.txt

@@ -1,6 +1,6 @@
 
 cet_build_plugin(ICARUSBNBEXTRetriever art::module
-    LIBRARIES
+    LIBRARIES PRIVATE
         art::Persistency_Common
         art::Utilities canvas::canvas
         cetlib::cetlib cetlib_except::cetlib_except

sbncode/BeamSpillInfoRetriever/ICARUSBNBRetriever/CMakeLists.txt

@@ -2,7 +2,7 @@ find_package(ifbeam)
 find_package(ifdh_art)
 
 cet_build_plugin(ICARUSBNBRetriever art::module
-    LIBRARIES
+    LIBRARIES PRIVATE
         sbn_POTTools
 	sbn_getFOM
         SQLite::SQLite3

sbncode/BeamSpillInfoRetriever/NuMIEXTRetriever/CMakeLists.txt

@@ -1,6 +1,6 @@
 
 cet_build_plugin(NuMIEXTRetriever art::module
-    LIBRARIES
+    LIBRARIES PRIVATE
         art::Persistency_Common
         art::Utilities canvas::canvas
         cetlib::cetlib cetlib_except::cetlib_except

sbncode/BeamSpillInfoRetriever/NuMIRetriever/CMakeLists.txt

@@ -2,7 +2,7 @@ find_package(ifbeam)
 find_package(ifdh_art)
 
 cet_build_plugin(NuMIRetriever art::module
-    LIBRARIES
+    LIBRARIES PRIVATE
         art::Persistency_Common
         art::Utilities canvas::canvas
         cetlib::cetlib cetlib_except::cetlib_except

sbncode/BeamSpillInfoRetriever/SBNDBNBEXTRetriever/CMakeLists.txt

@@ -2,7 +2,7 @@ find_package(ifbeam)
 find_package(ifdh_art)
 
 cet_build_plugin(SBNDBNBEXTRetriever art::module
-    LIBRARIES
+    LIBRARIES PRIVATE
         sbn_POTTools
 )
 

sbncode/BeamSpillInfoRetriever/SBNDBNBRetriever/CMakeLists.txt

@@ -2,7 +2,7 @@ find_package(ifbeam)
 find_package(ifdh_art)
 
 cet_build_plugin(SBNDBNBRetriever art::module
-    LIBRARIES
+    LIBRARIES PRIVATE
         sbn_POTTools
 	sbn_getFOM
 )

sbncode/BeamSpillInfoRetriever/SBNDBNBZEROBIASRetriever/CMakeLists.txt

@@ -2,7 +2,7 @@ find_package(ifbeam)
 find_package(ifdh_art)
 
 cet_build_plugin(SBNDBNBZEROBIASRetriever art::module
-    LIBRARIES
+    LIBRARIES PRIVATE
         sbn_POTTools
 	sbn_getFOM
 )

sbncode/CAFMaker/CMakeLists.txt

@@ -56,7 +56,7 @@ art_make_library( LIBRARY_NAME sbncode_CAFMaker
                   )
 
 cet_build_plugin ( CAFMaker art::module
-               LIBRARIES
+               LIBRARIES PRIVATE
                sbncode_CAFMaker
                sbnanaobj::StandardRecord
                larcorealg::Geometry

sbncode/Calibration/CMakeLists.txt

@@ -1,6 +1,6 @@
 
 cet_build_plugin( TrackCaloSkimmer art::module
-                       LIBRARIES
+                       LIBRARIES PRIVATE
                             art::Framework_Core
                             art::Framework_Services_Registry
                             art_root_io::TFileService_service
@@ -28,7 +28,7 @@ cet_build_plugin( TrackCaloSkimmer art::module
 )
 
 cet_build_plugin(TrackCaloSkimmerSelectStoppingTrack art::tool
-                      LIBRARIES
+                      LIBRARIES PRIVATE
                             art::Framework_Core
                             art::Framework_Services_Registry
                             art_root_io::TFileService_service
@@ -47,7 +47,7 @@ cet_build_plugin(TrackCaloSkimmerSelectStoppingTrack art::tool
 )
 
 cet_build_plugin(TrackCaloSkimmerSelectAnode2CathodeTrack art::tool
-                      LIBRARIES
+                      LIBRARIES PRIVATE
                             art::Framework_Core
                             art::Framework_Services_Registry
                             art_root_io::TFileService_service
@@ -61,7 +61,7 @@ cet_build_plugin(TrackCaloSkimmerSelectAnode2CathodeTrack art::tool
 )
 
 cet_build_plugin(TrackCaloSkimmerSelectAllTrack art::tool
-                      LIBRARIES
+                      LIBRARIES PRIVATE
 			    sbnobj::Common_Calibration_dict
                             art::Persistency_Common
                             art::Utilities canvas::canvas
@@ -71,7 +71,7 @@ cet_build_plugin(TrackCaloSkimmerSelectAllTrack art::tool
 )
 
 cet_build_plugin(TrackCaloSkimmerSelectClearCosmicMuon art::tool
-                      LIBRARIES
+                      LIBRARIES PRIVATE
 			    sbnobj::Common_Calibration_dict
                             art::Persistency_Common
                             art::Utilities canvas::canvas
@@ -81,7 +81,7 @@ cet_build_plugin(TrackCaloSkimmerSelectClearCosmicMuon art::tool
 )
 
 cet_build_plugin ( DataSelect art::module
-           LIBRARIES
+           LIBRARIES PRIVATE
                ifdh_art::IFDH_service
                art::Framework_Core
                art::Framework_Principal

sbncode/Cluster3D/CMakeLists.txt

@@ -56,8 +56,8 @@ set(    MODULE_LIBRARIES
           art_root_io::TFileService_service
           messagefacility::MF_MessageLogger
        )
-cet_build_plugin(Cluster3DSBN art::module LIBRARIES ${MODULE_LIBRARIES})
-cet_build_plugin(SnippetHit3DBuilderSBN art::tool LIBRARIES ${TOOL_LIBRARIES} SOURCE SnippetHit3DBuilderSBN_tool.cc)
+cet_build_plugin(Cluster3DSBN art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})
+cet_build_plugin(SnippetHit3DBuilderSBN art::tool LIBRARIES PRIVATE ${TOOL_LIBRARIES})
 set_property(SOURCE SnippetHit3DBuilderSBN_tool.cc APPEND PROPERTY COMPILE_DEFINITIONS EIGEN_FFTW_DEFAULT)
 
 install_headers()

sbncode/CosmicID/CMakeLists.txt

@@ -1,5 +1,5 @@
 cet_build_plugin( CRUMBS art::module
-      LIBRARIES
+      LIBRARIES PRIVATE
           art_root_io::TFileService_service
           fhiclcpp::fhiclcpp
           art::Persistency_Provenance canvas::canvas

sbncode/DetSim/CMakeLists.txt

@@ -31,8 +31,8 @@ set(	MODULE_LIBRARIES
 		FFTW3::FFTW3
 		)
 
-cet_build_plugin(AdjustSimForTrigger art::module LIBRARIES ${MODULE_LIBRARIES})
-cet_build_plugin(FilterSimEnergyDeposits art::module LIBRARIES ${MODULE_LIBRARIES})
+cet_build_plugin(AdjustSimForTrigger art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})
+cet_build_plugin(FilterSimEnergyDeposits art::module LIBRARIES PRIVATE ${MODULE_LIBRARIES})
 
 add_subdirectory(fcl)
 

sbncode/EventGenerator/MeVPrtl/CMakeLists.txt

@@ -2,7 +2,7 @@ add_subdirectory(Tools)
 add_subdirectory(config)
 
 cet_build_plugin( MeVPrtlGen art::module
-          LIBRARIES
+          LIBRARIES PRIVATE
               art::Framework_Core
               art::Framework_Services_Registry
               art_root_io::TFileService_service
@@ -24,7 +24,7 @@ cet_build_plugin( MeVPrtlGen art::module
 )
 
 cet_build_plugin( MeVPrtlTestRayTrace art::module
-                    LIBRARIES
+                    LIBRARIES PRIVATE
                         art::Framework_Core
                         art::Framework_Services_Registry
                         art_root_io::TFileService_service

sbncode/EventGenerator/MeVPrtl/Tools/ALP/CMakeLists.txt

@@ -5,7 +5,7 @@ art_make_library( LIBRARY_NAME sbncode_EventGenerator_MeVPrtl_ALP_ThreeBodyInteg
 )
 
 cet_build_plugin( Meson2ALP art::tool
-                        LIBRARIES
+                        LIBRARIES PRIVATE
                             art::Framework_Core
                             art::Framework_Services_Registry
                             art_root_io::TFileService_service
@@ -25,7 +25,7 @@ cet_build_plugin( Meson2ALP art::tool
 )
 
 cet_build_plugin( ALPMakeDecay art::tool
-                        LIBRARIES
+                        LIBRARIES PRIVATE
                             art::Framework_Core
                             art::Framework_Services_Registry
                             art_root_io::TFileService_service