Skip to content

Bug/py compatibility#5644

Open
AvinashYerra wants to merge 3 commits into
SQLMesh:mainfrom
AvinashYerra:bug/py-compatibility
Open

Bug/py compatibility#5644
AvinashYerra wants to merge 3 commits into
SQLMesh:mainfrom
AvinashYerra:bug/py-compatibility

Conversation

@AvinashYerra
Copy link
Copy Markdown

This PR fixes the issue #5639

  • Added 'parse_expand() converter function to parse the --expand argument
  • Updated @argument("--expand", type=parse_expand, ...) to use the converter function
  • The converter handles:
    • "true" → True (boolean)
    • "false"→ False (boolean)
    • Comma-separated values → List[str]

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 4, 2026

CLA assistant check
All committers have signed the CLA.

@argument
Copy link
Copy Markdown

argument commented Jan 19, 2026 via email

@mpreusse
Copy link
Copy Markdown

Will this be merged at some point? I'm running into the same 3.14 issues

@StuffbyYuki StuffbyYuki force-pushed the bug/py-compatibility branch from 2ecbeee to 860b317 Compare June 3, 2026 04:24
@StuffbyYuki
Copy link
Copy Markdown
Collaborator

@mpreusse Looking at this this week

@StuffbyYuki
Copy link
Copy Markdown
Collaborator

@AvinashYerra Can you add DCO checks on your commits?

@AvinashYerra AvinashYerra force-pushed the bug/py-compatibility branch from 860b317 to c5d340d Compare June 7, 2026 15:08
@AvinashYerra
Copy link
Copy Markdown
Author

Hey @StuffbyYuki, this is my first time doing the DCO thing. Please lmk if you want me to change anything

@StuffbyYuki StuffbyYuki force-pushed the bug/py-compatibility branch from c5d340d to 5d13b69 Compare June 7, 2026 20:58
@StuffbyYuki
Copy link
Copy Markdown
Collaborator

@AvinashYerra I ran the ci workfkows again but it looks like it failed. Here's some guidance on DCO checks!

Use git commit -s to add the sign-off automatically:

  • git commit -s -m "Your commit message"'

To fix a commit that is missing the sign-off:

  • git commit --amend -s

To add a sign-off to multiple commits:

  • git rebase HEAD~N --signoff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants