[Test] assert report-output content & add VersionChecker/GitHubRelease error-path tests; fixes #53#75
Merged
Merged
Conversation
… tests; fixes #53 Strengthen HTML/Markdown/Excel and ModelInspector generator tests to assert specific generated content (sections, classes, enums, sheet cells) instead of only file creation, and add mocked-HTTP tests for VersionChecker/GitHubRelease success payload, non-success status and malformed-JSON paths.
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the two acceptance criteria of #53.
Generator tests now assert content, not just file creation:
HtmlReportGenerator/MarkdownReportGenerator: assert the rendered output contains the package name/namespace, the section headers, and a representative class (Container) and enum (Unit/PIECE) from the recipe model (via the string-returningGenerateReportoverload).XlReportGenerator: re-open the workbook and assert theEClass/EEnum/EDataTypesheets carry the expected cells (Container,Recipe,capacity,Unit,PIECE,DataType).ModelInspector: replaceIs.Not.Emptywith assertions on the report's section markers (MULTIPLICITY RESULTS,INTERESTING CLASSES,MISSING DOCUMENTATION) and the inspected class.VersionChecker / GitHubRelease error paths (mocked HTTP layer):
QueryLatestReleaseAsyncreturns a populatedGitHubRelease(tag/body/url) - covers deserialization;ExecuteAsyncdoes not throw;ExecuteAsyncdoes not throw.Reuses the existing custom
HttpMessageHandlertest pattern. Full suite green (192 tests).Fixes #53.