Schema unification (WIP)#242
Open
ScriptRaccoon wants to merge 10 commits into
Open
Conversation
5 tasks
ScriptRaccoon
force-pushed
the
unify-schema-step-by-step
branch
from
e19d49a to
cd79a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea: combine categories and functors into a single table. Do the same with all other associated tables. Refactor the seed script, the deduction system, and actually, the whole application. Prepare for other categorical structures (#4) without introducing heavy code duplication. Also, remove the current code duplication between categories and functors.
This is the third attempt of doing this. The first one was never a PR, the second one was #224.
TODO:
NOTES
The id cannot be the only PK for properties since otherwise we cannot add the property "cocomplete" for, say, monoidal categories, since there is already such a property for categories. (A monoidal category is cocomplete when its underlying category is cocomplete and the tensor product preserves colimits in each variable, so this is a different notion.) So either we awkwardly rename the properties, or make the combination of (id, type) the PK.