Skip to content

ci: publish ship_geometry.db as a build artefact#41

Merged
olantwin merged 1 commit into
mainfrom
ci/geometry-artefact
Jun 26, 2026
Merged

ci: publish ship_geometry.db as a build artefact#41
olantwin merged 1 commit into
mainfrom
ci/geometry-artefact

Conversation

@olantwin

Copy link
Copy Markdown
Contributor

Summary

  • Adds a geometry pixi task that runs build_geometry into build/ship_geometry.db.
  • Wires it into the Build and Test workflow alongside the new artifact-name / artifact-path inputs of the shared pixi-cmake-build reusable workflow.
  • Each push to main (and each PR) now publishes the resulting GeoModel SQLite snapshot as a downloadable artefact named `ship_geometry-`.

Running `geometry` after `test` means a failing test still blocks the upload — we never expose a `.db` from a broken build.

Depends on ShipSoft/.github#5 (the upstream addition of `artifact-name` / `artifact-path` inputs). Once that merges this PR's workflow will start producing the artefact; until then the workflow run will fail at the input-validation stage.

Test plan

  • After feat(pixi-cmake-build): optional artifact upload after tasks .github#5 merges, the Build and Test workflow on this PR succeeds and the ship_geometry-<sha> artefact appears in the run summary.
  • Downloading the artefact yields a non-empty ship_geometry.db whose tables include PhysVols, LogVols, Shapes_*.
  • pixi run geometry locally produces build/ship_geometry.db.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@olantwin, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 34 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 000aa83c-cd2c-472c-b41d-2f4b71a1a032

📥 Commits

Reviewing files that changed from the base of the PR and between a38be63 and 19951e0.

📒 Files selected for processing (2)
  • .github/workflows/build-test.yml
  • pixi.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/geometry-artefact

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olantwin olantwin force-pushed the ci/geometry-artefact branch from 0348b56 to eaf337d Compare June 26, 2026 11:55
Adds a 'geometry' pixi task that runs build_geometry into
build/ship_geometry.db, and wires it into the Build and Test workflow
along with the new artifact-name / artifact-path inputs from the shared
pixi-cmake-build reusable workflow. Each push to main and each PR now
exposes the resulting GeoModel SQLite snapshot as a downloadable
artefact tagged with the commit SHA.

Running 'geometry' after 'test' ensures a failing test still blocks the
upload.
@olantwin olantwin force-pushed the ci/geometry-artefact branch from eaf337d to 19951e0 Compare June 26, 2026 12:21
@olantwin olantwin merged commit 93164e4 into main Jun 26, 2026
3 checks passed
@olantwin olantwin deleted the ci/geometry-artefact branch June 26, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant