Skip to content

build(pixi): add eigen-abi-devel and nlohmann_json#44

Merged
olantwin merged 1 commit into
mainfrom
pixi-add-eigen
Jun 26, 2026
Merged

build(pixi): add eigen-abi-devel and nlohmann_json#44
olantwin merged 1 commit into
mainfrom
pixi-add-eigen

Conversation

@olantwin

Copy link
Copy Markdown
Contributor

Summary

  • pixi run configure currently fails because CMake cannot satisfy find_dependency(Eigen3 5.0.1 CONFIG) called from GeoModelCoreConfig.cmake. Conda-forge eigen ships Eigen3Config.cmake under share/eigen3/cmake/, a path CMake does not search by default; depending on eigen-abi-devel puts the Config in a discoverable location (eigen-feedstock README case B).
  • Adds nlohmann_json alongside, since GeoModelToolsConfig.cmake calls find_dependency(nlohmann_json 3.12.0) and it is only pulled transitively today.
  • Mirrors the equivalent host-dep additions in the shipgeometry conda recipe (commits 0fbdc8b, 3632633, 56bbca2).

pixi.lock also drops the now-empty virtual-packages: block — an incidental normalization from re-running pixi install, unrelated to the dep change.

Test plan

  • pixi install resolves
  • pixi run configure succeeds (previously failed on Eigen3)
  • pixi run build builds all 169 targets
  • pixi run test — 33/33 pass

GeoModelCoreConfig.cmake calls find_dependency(Eigen3 5.0.1 CONFIG)
and conda-forge eigen ships Eigen3Config.cmake at share/eigen3/cmake/,
a path CMake does not search by default; eigen-abi-devel exposes the
Config in a discoverable location (eigen-feedstock README case B).

nlohmann_json is added alongside since GeoModelToolsConfig.cmake calls
find_dependency(nlohmann_json 3.12.0) and the package is only pulled
transitively today.

Mirrors the equivalent host-dep additions in the shipgeometry conda
recipe.
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@olantwin, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 11 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ea86434-ca1e-479f-8337-fd34fc53d6d3

📥 Commits

Reviewing files that changed from the base of the PR and between 00f0252 and 2076253.

⛔ Files ignored due to path filters (1)
  • pixi.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pixi.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pixi-add-eigen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olantwin olantwin merged commit a38be63 into main Jun 26, 2026
3 checks passed
@olantwin olantwin deleted the pixi-add-eigen branch June 26, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant