build(pixi): add eigen-abi-devel and nlohmann_json#44
Conversation
GeoModelCoreConfig.cmake calls find_dependency(Eigen3 5.0.1 CONFIG) and conda-forge eigen ships Eigen3Config.cmake at share/eigen3/cmake/, a path CMake does not search by default; eigen-abi-devel exposes the Config in a discoverable location (eigen-feedstock README case B). nlohmann_json is added alongside since GeoModelToolsConfig.cmake calls find_dependency(nlohmann_json 3.12.0) and the package is only pulled transitively today. Mirrors the equivalent host-dep additions in the shipgeometry conda recipe.
|
Warning Review limit reached
More reviews will be available in 3 minutes and 11 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
pixi run configurecurrently fails because CMake cannot satisfyfind_dependency(Eigen3 5.0.1 CONFIG)called fromGeoModelCoreConfig.cmake. Conda-forgeeigenshipsEigen3Config.cmakeundershare/eigen3/cmake/, a path CMake does not search by default; depending oneigen-abi-develputs the Config in a discoverable location (eigen-feedstock README case B).nlohmann_jsonalongside, sinceGeoModelToolsConfig.cmakecallsfind_dependency(nlohmann_json 3.12.0)and it is only pulled transitively today.shipgeometryconda recipe (commits0fbdc8b,3632633,56bbca2).pixi.lockalso drops the now-emptyvirtual-packages:block — an incidental normalization from re-runningpixi install, unrelated to the dep change.Test plan
pixi installresolvespixi run configuresucceeds (previously failed on Eigen3)pixi run buildbuilds all 169 targetspixi run test— 33/33 pass