add wallhero_thermostat_ACL-403STC1

[thinkaName]

Check all that apply

Type of Change

• WWST Certification Request
  • If this is your first time contributing code:
    • I have reviewed the README.md file
    • I have reviewed the CODE_OF_CONDUCT.md file
    • I have signed the CLA
  • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• Bug fix
• New feature
• Refactor

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have verified my changes by testing with a device or have communicated a plan for testing
• I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

[github-actions]

Duplicate profile check: Passed - no duplicate profiles detected.

[github-actions]

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/NxlwxaR7K4jA

[github-actions]

Test Results

   73 files    516 suites   0s ⏱️
2 937 tests 2 936 ✅ 0 💤 1 ❌
4 843 runs  4 842 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 3ea4e97.

♻️ This comment has been updated with latest results.

[github-actions]

File	Coverage
All files	95%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua	96%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua	97%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua	89%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/aqara/init.lua	94%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua	87%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua	97%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lazy_load_subdriver.lua	57%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua	92%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/resideo_korea/init.lua	90%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua	97%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/wallhero/init.lua	96%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/can_handle.lua	83%	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 3ea4e97

[cbaumler]

Hi @thinkaName, it looks like this PR branch is out of date with main. Please update it with the latest main and push the result. Then we can re-review.

[cjswedes]

I assume this -3 transformation is due to the 1st 3 components not being numbered buttons. Can you add a comment explaining the layout of the endpoints for this device? The test only shows 1 endpoint on the mock device, but this makes it seem like there are 30+ endpoints.

[cjswedes]

Perhaps you should default the main component or return nil (I think I prefer returning nil and causing a failure). Otherwise it will silently just use button1 even if its from an endpoint that is not for button1