Skip to content

fix: fix handling of yargs fail callback to handle message argument #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossiam merged 1 commit into from
Jun 9, 2026
Merged

fix: fix handling of yargs fail callback to handle message argument #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thin-books-appear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smartthings/cli": patch
---

Fixed error message when no command is given.
10 changes: 6 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@ export const buildInstance = (commands: CommandModule<object, any>[]): Argv => {
})
/* eslint-enable @typescript-eslint/naming-convention */
.completion('generate-completions-script', 'output completion script setup')
.fail((message, error, yargs) => {
if ('isAxiosError' in error && error.isAxiosError) {
.fail((message, error) => {
if (message) {
console.error(message)
console.error('Run with --help for usage details.')
} else if (error && 'isAxiosError' in error && error.isAxiosError) {
// We don't print axiosError.message here because it just duplicates the things
// we're displaying but unformatted.
const axiosError = error as AxiosError
Expand All @@ -43,8 +46,7 @@ export const buildInstance = (commands: CommandModule<object, any>[]): Argv => {
} else if (error) {
console.error(error.message)
} else {
console.error(message)
console.error(yargs.help())
console.error('An unknown error occurred.')
}

// eslint-disable-next-line no-process-exit
Expand Down
Loading