DKIM2#848
Open
juliebin wants to merge 40 commits into
Open
Conversation
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 86efa82. Configure here.
dkoerichbird
reviewed
Jun 9, 2026
| The wrapper stamps a new `Authentication-Results:` header with one | ||
| `dkim2=…` clause per directly-verified signature. RFC 8601 §5 states | ||
| that an MTA **MUST NOT** add a result to an existing header field, so | ||
| `verify()` always prepends a fresh AR header. `authservid` is required; |
Contributor
There was a problem hiding this comment.
authservidis required;
This can be read as the option being mandatory, which is not the case according to the table below.
| check before acting on the value. | ||
|
|
||
| `dkim2_overall` is one of the five verdict strings above. | ||
| `dkim2_overall` is one of the six verdict strings above. |
Contributor
There was a problem hiding this comment.
Maybe remove the number to avoid having to update it other times ("... one of the verdict strings above.").
…xt field clarifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What Changed
How To Test or Verify
PR Checklist
Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.
For example: If you are submitting a content change to one of the support documents, your checklist would include the:
If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:
All PRs Checklist
team-FEorteam-SAZ)Content Changes Checklist
examples/article.mdin the root of the project directory and on the momentum doc's preface articleDevelopment Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")
cypress/directory in the root of the projectNote
Low Risk
Documentation-only change with no application or config code; main caveat is operators following draft-spec guidance that may still change.
Overview
Adds a new Momentum 4 operator guide at
/momentum/4/dkim2for DKIM2 (draftietf-dkim-dkim2-spec-02), covering thedkim2 {}module, Luamsys.validate.dkim2.sign/verify, forwarder recipes,ar_clauses(), debugging reason codes, keys (reuse DKIM1 DNS), and known limitations—with a production staging warning because the wire format is not final.Updates
content/momentum/navigation.ymlso the page appears under Configuring Momentum beside the existing DKIM docs, with sub-nav links to signing and verifying sections.Reviewed by Cursor Bugbot for commit beef680. Bugbot is set up for automated code reviews on this repo. Configure here.