Fix fuzzy set union boundaries#14761
Open
AbodiDawoud wants to merge 1 commit into
Open
Conversation
diusazzad
reviewed
Jun 6, 2026
diusazzad
left a comment
There was a problem hiding this comment.
Could you please add a small note in the PR description or docstring explaining the rationale behind using the average for the peak and right_boundary? It would be great to know if this follows a specific fuzzy logic convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #11871.
This fixes
FuzzySet.union()so the returned triangular fuzzy set keeps its fields in boundary order:left_boundary: minimum left boundarypeak: maximum peakright_boundary: maximum right boundaryPreviously the method placed the maximum right boundary in
peakand the average peak inright_boundary, which produced invalid output such aspeak=0.6, right_boundary=0.35.Checklist:
Local checks:
.venv/bin/python -m doctest -v fuzzy_logic/fuzzy_operations.py.venv/bin/python -m pytest fuzzy_logic/fuzzy_operations.py.venv/bin/ruff check fuzzy_logic/fuzzy_operations.py.venv/bin/ruff format --check fuzzy_logic/fuzzy_operations.py.venv/bin/mypy --ignore-missing-imports fuzzy_logic/fuzzy_operations.pygit diff --check