refactor(maths): use direct iteration instead of index-based loops in persistence.py#14767
Open
fauzan171 wants to merge 1 commit into
Open
Conversation
… persistence.py Replace for i in range(len(numbers)) with for number in numbers in both multiplicative_persistence() and additive_persistence(). Direct iteration is more Pythonic and avoids unnecessary index lookups.
algorithms-keeper
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
for i in range(len(numbers))withfor number in numbersin bothmultiplicative_persistence()andadditive_persistence()functions.Changes
for number in numbers) instead of index-based loops (for i in range(len(numbers)))multiplicative_persistence()andadditive_persistence()Why
Direct iteration is more Pythonic (PEP 20: Simple is better than complex) and avoids unnecessary index lookups (
numbers[i]). The behavior is unchanged and all existing doctests pass.Checklist