docs: clarify curl(grad(f)) residual is discretization error#1523
Open
rajeeja wants to merge 2 commits into
Open
docs: clarify curl(grad(f)) residual is discretization error#1523rajeeja wants to merge 2 commits into
rajeeja wants to merge 2 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1522.
The docs showed
curl(grad(f))values of O(1–10) with the caption "Should ≈ 0", with no explanation. This confused a user into filing a bug report.Changes:
curl(grad(f)) = 0holds exactly only in the continuous setting; UXarray's gradient and curl are independent finite-volume stencils that don't form a discrete de Rham complexIdentity verified: {max_curl_grad < 1e-10}boolean (which was False anyway for a non-trivial field)