Ensure out-of-tree API builds succeed across all platforms#8252
Open
fuzyll wants to merge 2 commits into
Open
Conversation
Also forces Release mode in these scripts by default because apparently the typical default is Debug.
When building the API out-of-tree on Ubuntu 22.04 with clang 14.0, I encountered some build failures. These changes fixed that. I don't fully understand why clang believes they are necessary, but it appears to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user last week complained that we had broken the ability to build the API and some examples with a change we made. It wasn't broken for us, since we build in-tree, but customers don't have the rest of our source code.
As it turns out, @CouleeApps wrote a nice little script that lets us test this out-of-tree build process in February 2022 so we wouldn't have this problem. Unfortunately, it appears to have been taken out of our build process pretty quickly because it added a lot of overall time to builds.
I've gone ahead and set up a new nightly process for ensuring we are made aware when we break builds for customers. To do this, I've split the original script @CouleeApps wrote into two–one for us to test in-tree builds with, and one to test out-of-tree builds with. (They were previously both in the same script, so the former would fail with my setup that approximates a customer's environment.)
In the process of doing this, I discovered that the Triage example would no longer build on Windows and the API itself would not build with clang 14 on Ubuntu 22.04. This PR fixes those issues in the quickest and most straight-forward way I could figure out how.
I have separately run a full build with these API changes through CI as well, which has succeeded. Just want someone else to look these over and ensure they look reasonable before I merge them.