Reapply "Fix open world public types" (#8802)#8810
Open
tlively wants to merge 2 commits into
Open
Conversation
This reverts commit 9e3b947. Beyond reapplying the original commit, this adds special handling when `func` is exposed so that we avoid considering function types used only to declare unreferenced functions public. This avoids an assertion failure in MinimizeRecGroups when a previous pass like DAE optimizes an unreferenced function's type to differ from a public function type only by e.g. the exactness of a reference when custom descriptors is disabled. The assertion in MinimizeRecGroups is checking that all public types are distinguishable from each other given the enabled feature set. This is something we enforce when parsing input modules, so it makes sense to keep as an invariant of the IR. The change to consider types used only for unreferenced functions private lets us maintain that invariant without giving up optimization power unnecessarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9e3b947.
Beyond reapplying the original commit, this adds special handling when
funcis exposed so that we avoid considering function types used only to declare unreferenced functions public. This avoids an assertion failure in MinimizeRecGroups when a previous pass like DAE optimizes an unreferenced function's type to differ from a public function type only by e.g. the exactness of a reference when custom descriptors is disabled. The assertion in MinimizeRecGroups is checking that all public types are distinguishable from each other given the enabled feature set. This is something we enforce when parsing input modules, so it makes sense to keep as an invariant of the IR. The change to consider types used only for unreferenced functions private lets us maintain that invariant without giving up optimization power unnecessarily.