Skip to content

+ DocumentFragment.textContent#278

Open
iacore wants to merge 3 commits into
WebReflection:mainfrom
iacore:patch-1
Open

+ DocumentFragment.textContent#278
iacore wants to merge 3 commits into
WebReflection:mainfrom
iacore:patch-1

Conversation

@iacore

@iacore iacore commented Jun 9, 2024

Copy link
Copy Markdown

fix #231

@WebReflection

WebReflection commented Jun 9, 2024

Copy link
Copy Markdown
Owner

There is no test, please add one, thanks. never mind, I've seen tests now ...

Comment thread esm/interface/document-fragment.js Outdated
@iacore iacore marked this pull request as draft June 9, 2024 19:40
@iacore

iacore commented Jun 9, 2024

Copy link
Copy Markdown
Author

the plot thickens. i may end up adding more features.

@WebReflection

Copy link
Copy Markdown
Owner

I am not going to Approve and run until this is draft ... please let me know when this is not draft anymore, thanks!

@iacore iacore marked this pull request as ready for review June 12, 2024 09:42
@iacore

iacore commented Jun 12, 2024

Copy link
Copy Markdown
Author

So, I discovered another bug that I don't know how to fix. Can you fix it? I've added a test for it.

@WebReflection

Copy link
Copy Markdown
Owner

I am not sure I know what bug you are talking about ... but if it has nothing to do with textContent it should likely not be part of this PR?

@iacore

iacore commented Jun 12, 2024

Copy link
Copy Markdown
Author

fixed it. moved it to #279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

null textContent value for DocumentFragment

2 participants