Skip to content

fix(compliance): add trailing slash to preflight-compliance fetch#3043

Open
AGMASO wants to merge 1 commit into
mainfrom
fix/compliance-preflight-trailing-slash
Open

fix(compliance): add trailing slash to preflight-compliance fetch#3043
AGMASO wants to merge 1 commit into
mainfrom
fix/compliance-preflight-trailing-slash

Conversation

@AGMASO

@AGMASO AGMASO commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

General Changes

  • The app sets trailingSlash: true in next.config.js, so requests to /api/preflight-compliance (without a trailing slash) get a 308 redirect to the slashed path. Combined with the cached permanent redirect this loops in the browser and surfaces as ERR_TOO_MANY_REDIRECTS, breaking the compliance gate. Call the canonical slashed path to avoid the redirect.

Developer Notes

Add any notes here that may be helpful for reviewers.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

The app sets `trailingSlash: true` in next.config.js, so requests to
`/api/preflight-compliance` (without a trailing slash) get a 308 redirect
to the slashed path. Combined with the cached permanent redirect this
loops in the browser and surfaces as ERR_TOO_MANY_REDIRECTS, breaking the
compliance gate. Call the canonical slashed path to avoid the redirect.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
interface Ready Ready Preview, Comment Jun 23, 2026 11:49am

Request Review

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.29 MB (-19 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants