Skip to content

Pin protobuf version to 6.33.5#11045

Draft
tannewt wants to merge 3 commits into
mainfrom
tannewt-patch-2
Draft

Pin protobuf version to 6.33.5#11045
tannewt wants to merge 3 commits into
mainfrom
tannewt-patch-2

Conversation

@tannewt
Copy link
Copy Markdown
Member

@tannewt tannewt commented Jun 4, 2026

Add protobuf version pinning due to Perfetto package issue.

Add protobuf version pinning due to Perfetto package issue.
Comment thread requirements-dev.txt Outdated
Co-authored-by: Dan Halbert <halbert@adafruit.com>
dhalbert
dhalbert previously approved these changes Jun 4, 2026
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix!

@dhalbert
Copy link
Copy Markdown
Collaborator

dhalbert commented Jun 4, 2026

@copilot why is each board built twice when the PR branch is on adafruit instead of coming from a branch of a fork?

Copy link
Copy Markdown

Copilot AI commented Jun 4, 2026

@copilot why is each board built twice when the PR branch is on adafruit instead of coming from a branch of a fork?

Because .github/workflows/build.yml is triggered by both push and pull_request (on: push and on: pull_request). For a PR branch in adafruit/circuitpython, the same commits generate both events in this repo, so the board matrix runs twice. For a fork PR, the fork’s push run happens in the fork, while the upstream repo shows only the pull_request run.

Copilot AI requested a review from dhalbert June 4, 2026 22:57
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannewt looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants