Skip to content
This repository was archived by the owner on Oct 12, 2021. It is now read-only.

feat(app-shell): Update for v4#139

Open
lacolaco wants to merge 1 commit into
angular:masterfrom
lacolaco:app-shell-v4
Open

feat(app-shell): Update for v4#139
lacolaco wants to merge 1 commit into
angular:masterfrom
lacolaco:app-shell-v4

Conversation

@lacolaco

Copy link
Copy Markdown
  • Update @angular/* version to v4
  • Fix specs around DebugElement
  • Use InjectionToken<T>

@robwormald

Copy link
Copy Markdown

this LGTM 👍

@lacolaco

Copy link
Copy Markdown
Author

rebased on master

@lacolaco

Copy link
Copy Markdown
Author

What is blocking this PR?

@lacolaco

lacolaco commented Jun 12, 2017

Copy link
Copy Markdown
Author

rebased on master @alxhub

@mgechev mgechev self-requested a review June 12, 2017 02:39
@mwent-cray

Copy link
Copy Markdown

Kinda hoping this can be released soon - as with updating I hope that it will fix #172 automagically

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants