Skip to content

Clean class and function files as per PSR-4#98

Open
szepeviktor wants to merge 7 commits into
antecedent:masterfrom
szepeviktor:composer
Open

Clean class and function files as per PSR-4#98
szepeviktor wants to merge 7 commits into
antecedent:masterfrom
szepeviktor:composer

Conversation

@szepeviktor

Copy link
Copy Markdown

Closes #97

@antecedent What do you think?

BTW Please consider following PSR-12 coding style.

@szepeviktor

szepeviktor commented Nov 24, 2019

Copy link
Copy Markdown
Author

I'm stuck with the following error. Please help me.

PHP Warning:  Composer\Autoload\includeFile(/home/viktor/tmp/patchwork/src/Config/State.php): 
failed to open stream: "Patchwork\CodeManipulation\Stream::stream_open" call failed 
in /home/viktor/tmp/patchwork/vendor/composer/ClassLoader.php on line 444

PHP Warning:  Composer\Autoload\includeFile(): 
Failed opening '/home/viktor/tmp/patchwork/patchwork-composer/composer/../../src/Config/State.php' for inclusion (include_path='.:/usr/share/php') 
in /home/viktor/tmp/patchwork/vendor/composer/ClassLoader.php on line 444

PHP Fatal error:  Uncaught Error: 
Class 'Patchwork\Config\State' not found 
in /home/viktor/tmp/patchwork/src/Config/functions.php:88

Stack trace:
#0 /home/viktor/tmp/patchwork/src/CodeManipulation/functions.php(130): Patchwork\Config\isBlacklisted('/home/viktor/tm...')
#1 /home/viktor/tmp/patchwork/src/CodeManipulation/Stream.php(45): Patchwork\CodeManipulation\shouldTransform('/home/viktor/tm...')
#2 /home/viktor/tmp/patchwork/vendor/composer/ClassLoader.php(444): Patchwork\CodeManipulation\Stream->stream_open('/home/viktor/tm...', 'rb', 16512, NULL)
#3 /home/viktor/tmp/patchwork/vendor/composer/ClassLoader.php(444): include()
#4 /home/viktor/tmp/patchwork/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/home/viktor/tm...')
#5 [internal function]: Composer\Autoload\ClassLoader->loadClass('Patchwork\\Confi...')
#6 /home/viktor/tmp/patchwork/src/Config/functions.php(152): spl_autoload_call('Patchwork\\Confi...')
#7 /home/viktor/tmp/patchwork/src/CodeManipulation/Actions/RedefinitionOfInternals/functions.php in /home/viktor/tmp/patchwork/src/Config/functions.php on line 88

@szepeviktor

szepeviktor commented Nov 24, 2019

Copy link
Copy Markdown
Author

I think Patchwork patches Composer :)
Could we exclude Composer and our classes while patching?

@szepeviktor

Copy link
Copy Markdown
Author

Done.

@szepeviktor

szepeviktor commented Nov 24, 2019

Copy link
Copy Markdown
Author

@antecedent Could you help fix the remaining failing test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composer-izing

1 participant