Remove extra buffer copy in StompNIOSSLTransport#2107
Merged
Conversation
Optimizes the StompNIOSSLTransport by removing the unnecessary extra byte array allocation and buffer copy when processing frames
tabish121
approved these changes
Jun 11, 2026
tabish121
left a comment
tabish121
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to go straight to the ByteBuffer, so long as the tests pass
Contributor
Author
|
As an aside, MQTT also has the same issue but is not as trivial to fix and has more cleanup to replace it including tests. I figure not as many people use MQTT but it's something that could be done in another PR I'll let the tests pass and if no issue i'll merge. |
github-project-automation
Bot
moved this from Backlog
to Done
in Apache ActiveMQ v6.3.0
cshannon
added a commit
that referenced
this pull request
Jun 12, 2026
cshannon
added a commit
that referenced
this pull request
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizes the StompNIOSSLTransport by removing the unnecessary extra byte array allocation and buffer copy when processing frames