CAMEL-19551: camel-jpa ensure tests have assertions#23768
Open
gbhavya07 wants to merge 1 commit into
Open
Conversation
apupier
reviewed
Jun 5, 2026
Contributor
apupier
left a comment
There was a problem hiding this comment.
all the modified tests already have assertions. I'm not sure it is adding a lot of clarity in these cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit assertions for startup operations in camel-jpa tests.
Several tests invoked
consumer.start()orcontext.start()without directly asserting successful execution. This change wraps those operations withassertDoesNotThrow, making the expected startup behavior explicit and improving test clarity.Updated tests:
This is a test-only change and does not modify component behavior.
Validation:
./mvnw -pl components/camel-jpa -DskipITs testTarget
mainbranch)Tracking
Apache Camel coding standards and style
I checked that each commit in the pull request has a meaningful subject line and body.
I ran the relevant module tests locally and verified they pass.