Fix userdata details being improperly serialized#295
Open
bddvlpr wants to merge 1 commit into
Open
Conversation
Userdata details are now parsed and processed by cloudstack-go. We simply pass the key/values and let cloudstack-go do the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of this PR, the provider incorrectly passes user data details to CloudStack, causing templates to render improperly without producing any visible errors.
The provider currently sends user data details in the following format:
However, recent versions of CloudStack expect details to be provided as key-value pairs in the following format:
The previously used format appears to be deprecated or is no longer supported, resulting in user data not being processed correctly. This issue has already been fixed upstream in cloudstack-go apache/cloudstack-go@3aaf3aa which is included in v2.19.0.