Skip to content

THRIFT-5855: Add netstd fuzzers#3203

Closed
mhlakhani wants to merge 1 commit into
apache:masterfrom
mhlakhani:netstd_fuzzers
Closed

THRIFT-5855: Add netstd fuzzers#3203
mhlakhani wants to merge 1 commit into
apache:masterfrom
mhlakhani:netstd_fuzzers

Conversation

@mhlakhani

@mhlakhani mhlakhani commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Experimental RFC for netstd fuzzers. Requesting review for this one as I'm not sure if this is idiomatic C#, or how to build these projects.

I'm worried about bitrot here. Makefile inclusion will hopefully ensure these build in CI and we don't bitrot the build, but if no one's running these fuzzers regularly (due to lack of oss-fuzz support) I'm not sure how impactful these will be.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mhlakhani mhlakhani requested a review from Jens-G August 25, 2025 23:32

@Jens-G Jens-G left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the new source files lack the ASF header.

@Jens-G Jens-G added the c# Pull requests that update C# code label Aug 26, 2025
@Jens-G

Jens-G commented Sep 8, 2025

Copy link
Copy Markdown
Member

I checked twice that I installed sharpfuzz according to the docs but I always get

Build succeeded in 1.2s
Instrumenting assemblies for fuzzing ...
Skipping Thrift.FuzzTests.CompactRoundtripAFL.dll
Skipping Thrift.FuzzTests.BinaryParseLibfuzzer.dll
Instrumenting Microsoft.Extensions.Logging.dll
./buildfuzzers.sh: line 121: sharpfuzz: command not found

I used the docker jammy build environment, if that is relevant.

@Jens-G

Jens-G commented Sep 15, 2025

Copy link
Copy Markdown
Member

Ping?

@Jens-G

Jens-G commented Nov 14, 2025

Copy link
Copy Markdown
Member

see also #3235

@mhlakhani

Copy link
Copy Markdown
Contributor Author

ah, sorry for the delay here, life got in the way - I'll make a pass this weekend

@mhlakhani

Copy link
Copy Markdown
Contributor Author

it looks like after the move to .net 10, this may not be possible, as sharpfuzz doesn't seem to support it. I'll have to do some more research (I'm not a .NET expert unfortunately)

@Jens-G

Jens-G commented Nov 25, 2025

Copy link
Copy Markdown
Member

Well, net10 was released only few weeks ago. They might need some time. Since it is the current LTS I would expect it will be supported soon.

@Jens-G Jens-G marked this pull request as draft December 14, 2025 22:16
@Jens-G

Jens-G commented Dec 14, 2025

Copy link
Copy Markdown
Member

Converted to draft. Please make it a PR again (via "ready to review") if you completed it.

@Jens-G

Jens-G commented Apr 17, 2026

Copy link
Copy Markdown
Member

Superseded by #3402

@Jens-G Jens-G closed this Apr 17, 2026
@mergeable mergeable Bot added the build and general CI cmake, automake and build system changes label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build and general CI cmake, automake and build system changes c# Pull requests that update C# code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants