WICKET-7187 type for JavaScript content item, and new JavaScript import map item#1498
Draft
jstuyts wants to merge 2 commits into
Draft
WICKET-7187 type for JavaScript content item, and new JavaScript import map item#1498jstuyts wants to merge 2 commits into
jstuyts wants to merge 2 commits into
Conversation
…a JavaScript import map header item. The first attempt was to make a base class for `AbstractJavaScriptReferenceHeaderItem` and `JavaScriptContentHeaderItem`, and move the type to there. But `setType(...)` in the former returns `AbstractJavaScriptReferenceHeaderItem`. Moving the type information up the hierarchy would break backward compatibility. The (simple) code for managing the type has simply been copied now. `JavaScriptReferenceType` should be called `JavaScriptType` now, but that would also break backward compatibility. This has been documented. If the new features are not used, almost everything works as before. The only change to current behavior is that `equals(...)` and `hashCode(...)` of `JavaScriptContentHeaderItem` now also use the type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added type to JavaScript content header items, and added a JavaScript import map header item.
The first attempt was to make a base class for
AbstractJavaScriptReferenceHeaderItemandJavaScriptContentHeaderItem, and move the type to there. ButsetType(...)in the former returnsAbstractJavaScriptReferenceHeaderItem. Moving the type information up the hierarchy would break backward compatibility. The (simple) code for managing the type has simply been copied now.JavaScriptReferenceTypeshould be calledJavaScriptTypenow, but that would also break backward compatibility. This has been documented.If the new features are not used, almost everything works as before. The only change to current behavior is that
equals(...)andhashCode(...)ofJavaScriptContentHeaderItemnow also use the type.