Integrate [DurableExecution] with the Annotations source generator#2410
Open
GarrettBeatty wants to merge 2 commits into
Open
Integrate [DurableExecution] with the Annotations source generator#2410GarrettBeatty wants to merge 2 commits into
GarrettBeatty wants to merge 2 commits into
Conversation
GarrettBeatty
force-pushed
the
gcbeatty/durable-annotations
branch
from
ab1af0b to
a921009
Compare
GarrettBeatty
force-pushed
the
gcbeatty/durable-annotations
branch
from
a921009 to
925f3b5
Compare
GarrettBeatty
force-pushed
the
gcbeatty/durable-annotations
branch
from
45da58d to
35c966c
Compare
GarrettBeatty
commented
Jun 23, 2026
| <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> | ||
| <!-- src\Function is a separate, self-contained project. Exclude its subtree so this project's | ||
| default globs don't pick up its sources or generated obj\AssemblyInfo (which causes CS0579). --> | ||
| <DefaultItemExcludes>$(DefaultItemExcludes);src\**</DefaultItemExcludes> |
Contributor
Author
There was a problem hiding this comment.
was running into build issue so fixed this too
GarrettBeatty
requested review from
normj and
philasmar
and removed request for
a team
GarrettBeatty
commented
Jun 23, 2026
| // the exact entry point the hand-written and executable test functions call, so the | ||
| // checkpoint/replay/history behavior is identical. | ||
| [LambdaFunction] | ||
| [DurableExecution] |
Contributor
Author
There was a problem hiding this comment.
i manually deployed this too and also played around with updating the attributes and checking that they reflected in the template too
Add a [DurableExecution] attribute (in Amazon.Lambda.Annotations) and source generator support so a method annotated with [LambdaFunction] + [DurableExecution] generates: - a typed-envelope handler wrapper delegating to DurableFunction.WrapAsync<TInput[,TOutput]> - a DurableConfig block on the function resource in the generated CFN/SAM template - lambda:CheckpointDurableExecution / lambda:GetDurableExecutionState IAM permissions (per-function inline policy; skipped when an explicit Role is set) Validation gates (AWSLambda0140-0143) require durable functions to be executable (OutputKind), Zip-packaged, and have the (TInput, IDurableContext) -> Task/Task<TOutput> signature; combining with another event attribute reuses the existing AWSLambda0102. The generated WrapAsync call emits explicit generic type arguments because method-group arguments cannot be inferred for the Func<,,> parameter (CS0411). fiox build annotations updates updates update docs pr comments
GarrettBeatty
force-pushed
the
gcbeatty/durable-annotations
branch
from
183524b to
5a5447e
Compare
normj
reviewed
Jun 23, 2026
| // Assembly::Type::Method), which LambdaFunctionModel.Handler already derives from IsExecutable. So no | ||
| // OutputKind gate is needed here. | ||
|
|
||
| // Image packaging strips Handler/Runtime from the function resource, which the durable |
Member
There was a problem hiding this comment.
I don't understand this comment and why image functions don't work. Especially since that is how we tell customers to test the preview. Maybe a quick sync up between us to help me understand what is causing the issue.
Contributor
Author
There was a problem hiding this comment.
Might be AI slop. I also asked Claude about this, I think he mentioned the other annotations have the same limitation. I'll double check
Contributor
Author
There was a problem hiding this comment.
fixed in 3bee3f5. claude incorrectly assumed some things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a [DurableExecution] attribute (in Amazon.Lambda.Annotations) and source generator support so a method annotated with [LambdaFunction] + [DurableExecution] generates:
Issue #, if available:
#2418
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.