test(policy-registry): cross-validate inactive-feature dispatch#158
Merged
Merged
Conversation
stevieraykatz
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
rayyan224
as code owners
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟢 B20FactoryLib.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockPolicyRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 99.86% | 99.88% | 100.00% | 100.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
stevieraykatz
force-pushed
the
fork-tests/policy-registry-inactive-dispatch
branch
from
03b7857 to
6532c39
Compare
✅ Fork tests: all 613 passedbase/base is fully in sync with the base-std spec. |
While a feature is inactive, the PolicyRegistry dispatcher routes view selectors to ABI dispatch but sends every other selector through the activation gate first, so error behavior depends on activation state: an unknown selector or malformed write returns FeatureNotActivated instead of being classified. Clients and monitoring can't then distinguish an inactive feature from bad calldata near activation boundaries. Add fork cross-validation for the dispatcher's inactive path: - run-fork-tests.sh: SKIP_ACTIVATE env var leaves named features (by name or 0x id, case-insensitive) un-activated so the inactive path is reachable; default keeps every feature active, so the existing run is unchanged. - test/unit/PolicyRegistry/dispatch_inactive.t.sol: fork-only tests that views stay callable while inactive, a malformed view reaches decode (not the gate), writes stay gated by FeatureNotActivated, and an unknown selector is classified rather than masked by the gate. The last encodes a not-yet-shipped dispatch fix, so it's gated behind POLICY_DISPATCH_FIX. - FORK_TESTING.md: document both env vars and the inactive-path invocation. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
stevieraykatz
force-pushed
the
fork-tests/policy-registry-inactive-dispatch
branch
from
6532c39 to
614d48d
Compare
ilikesymmetry
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds fork cross-validation for the
PolicyRegistryprecompile's inactive-feature dispatch path, which the existing fork suite never exercises (it activates every feature before running).While a feature is inactive, the dispatcher routes view selectors to ABI dispatch but sends every other selector through the activation gate before classification. As a result, error behavior depends on activation state: an unknown selector or a malformed write returns
FeatureNotActivatedrather than being classified as an unknown-selector / ABI-decode error. Clients, tests, and monitoring then can't distinguish "feature inactive" from "bad calldata" near activation boundaries.Changes
script/run-fork-tests.sh— newSKIP_ACTIVATEenv var leaves named features un-activated (matched by canonical name or raw0x…id, case-insensitive), making the inactive path reachable. Default is empty, so the standard cross-validation run activates everything exactly as before.test/unit/PolicyRegistry/dispatch_inactive.t.sol— fork-only regression tests (the SolidityMockPolicyRegistrymodels no activation gate, so these run only underLIVE_PRECOMPILES). They normalize the feature to inactive, then assert:FeatureNotActivated;Case 4 encodes a dispatch-ordering fix that isn't in the pinned Rust impl yet, so it's gated behind
POLICY_DISPATCH_FIX— leave it unset against stock builds (keeps the run green); set it once the fix is in the build to enforce the regression.FORK_TESTING.md— documents both env vars and the inactive-path invocation.Testing
forge build,forge fmt --check, andforge lintpass; all four tests compile and skip cleanly in mock mode. Live cross-validation runs under the base-anvil toolchain:SKIP_ACTIVATE=POLICY_REGISTRY ./script/run-fork-tests.sh \ --match-contract PolicyRegistryDispatchInactive