build: remove Windows CE platform support#35
Merged
Merged
Conversation
Windows CE / Windows Mobile is an obsolete target. Its support was woven through the Windows OS layer as DB_WINCE conditionals alongside the desktop Windows code, plus a dedicated Visual Studio build tree and ADO.NET project generation. Remove it, keeping the desktop Windows paths the conditionals fell through to. OS layer and headers: - Resolve every DB_WINCE / _WIN32_WCE conditional in src/os_windows/ and src/dbinc/ to its desktop-Windows branch: os_open.c, os_map.c, os_config.c, os_handle.c, os_clock.c, os_errno.c, os_flock.c, os_getenv.c, os_rename.c, os_rw.c, os_stat.c, os_dir.c, mut_win32.c, win_db.h, globals.h, mutex_int.h, atomic.h, env_globals.c, os_atomic.c. - Drop the WinCE-only db_atomic_t "dummy" field and the WINCE_ATOMIC_MAGIC writes that padded it. - db_env_set_win_security is now unconditional on Windows; update its prototype guard in the generated ext_prot.in / ext_def.in. - Remove the WinCE vsnprintf shim in the SQL adapter. Build system: - Delete build_wince/, dist/wince_config.in, dist/win_projects/db_wince.projects and projects_wince.template.xml, dist/adodotnet/gen_wince_project.xq.in and testce.2008.csproj, dist/errno.h (only copied into build_wince), and lang/sql/sqlite/Makefile.arm-wince-mingw32ce-gcc. - Remove the WinCE steps from s_windows, s_windows_dsp, s_sql_drivers, and the WinCE variables and branches from the shared ADO.NET adapt_*.xq.in scripts. - Drop the build_wince filters from the validate scripts and the WinCE comment in clib_port.in and srcfiles.in. Docs: - Delete the Windows Mobile installation pages and remove their chapter from the installation table of contents. No configure regeneration is required: DB_WINCE was never an Autoconf template, only set by the deleted build_wince config header and the VS preprocessor. Incidental historical mentions in reference prose and vendored third-party files (config.sub, libtool, the SQLite amalgamation) are left untouched.
# Conflicts: # dist/validate/s_chk_tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove Windows CE / Windows Mobile platform support.
Why
Windows CE is an obsolete target. Its support was woven through the Windows OS
layer as
DB_WINCEconditionals alongside the desktop Windows code, plus adedicated Visual Studio build tree and ADO.NET project generation, all adding
maintenance cost for a platform that is no longer built or tested.
Changes
OS layer and headers:
DB_WINCE/_WIN32_WCEconditional insrc/os_windows/andsrc/dbinc/to its desktop-Windows branch (os_open.c, os_map.c, os_config.c,os_handle.c, os_clock.c, os_errno.c, os_flock.c, os_getenv.c, os_rename.c,
os_rw.c, os_stat.c, os_dir.c, mut_win32.c, win_db.h, globals.h, mutex_int.h,
atomic.h, env_globals.c, os_atomic.c).
db_atomic_tdummy field and theWINCE_ATOMIC_MAGICwrites that padded it.
db_env_set_win_securityis now unconditional on Windows; its generatedprototype guard is updated accordingly.
vsnprintfshim in the SQL adapter.Build system:
build_wince/,dist/wince_config.in, the WinCE win_projects files,the WinCE ADO.NET generator and
testce.2008.csproj,dist/errno.h(onlycopied into
build_wince), and the SQLite WinCE makefile.s_windows,s_windows_dsp,s_sql_drivers,the shared ADO.NET
adapt_*.xq.inscripts, the validate scripts, and theclib_port.in/srcfiles.incomments.Docs:
installation table of contents.
Scope
No
configureregeneration is needed:DB_WINCEwas never an Autoconftemplate, only set by the deleted
build_winceconfig header and the VisualStudio preprocessor. Incidental historical mentions in reference prose and
vendored third-party files (config.sub, libtool, the SQLite amalgamation) are
left untouched.
Verification
Builds clean with meson (macOS clang) after the removal. The
src/os_windows/sources are compiled only on Windows (not by the gating CI matrix); each
DB_WINCEblock was resolved to the existing desktop branch and the editedfiles were checked for brace/preprocessor balance.