feat(BBBSearch): add search component#39
Open
AtilaU19 wants to merge 1 commit into
Open
Conversation
Arthurk12
requested changes
Jun 11, 2026
| /** | ||
| * A search input component with built-in debounce, clear button, and loading state. | ||
| * | ||
| * Supports both **uncontrolled** (default) and **controlled** modes: |
Member
There was a problem hiding this comment.
Please remove the JSDoc comments from L9-L23. The README documentation is sufficient, and having them here causes the text to appear in the BBBSearch story in Storybook, polluting the UI when there is too much content - see screenshot below. The expected pattern is just 1 to 3 sentences giving a brief, high-level description of the component - see other components.
| ); | ||
| }; | ||
|
|
||
| /** Controlled mode — parent manages the value. */ |
Member
There was a problem hiding this comment.
The controlled mode example displays 2 clear buttons:
| @@ -0,0 +1,73 @@ | |||
| # BBBSearch | |||
Member
There was a problem hiding this comment.
Add a mention to this component in the project README - under available components.
AtilaU19
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the BBBSearch component.
Features:
Notes
BBBSearch is intentionally kept free of any GraphQL/Apollo dependency. Loading state is passed in via isLoading, allowing the caller to derive it from a subscription, a query, or any other async source. This keeps the component reusable outside the BBB core.
Closes Issue(s)
Closes #35