Skip to content

Revamp agents panel profiles#1132

Open
klopez4212 wants to merge 23 commits into
mainfrom
kennylopez-agents-panel
Open

Revamp agents panel profiles#1132
klopez4212 wants to merge 23 commits into
mainfrom
kennylopez-agents-panel

Conversation

@klopez4212

Copy link
Copy Markdown
Contributor

Summary

  • Treat personas as agent profiles from the Agents panel and open the sidebar profile instead of the old instance dropdown.
  • Rework agent/team cards, create-agent/team modal styling, and profile sidebar management sections.
  • Add Goose app avatar asset resolution for imported persona markdown, including poster/WebM/HEVC assets.

Notes

  • This intentionally adds the full Goose avatar media bundle (~281 MB under desktop/src/shared/assets/goose-avatars) so imported app-avatar:* persona files can render locally.

Validation

  • cd desktop && pnpm check
  • cd desktop && pnpm test
  • cd desktop && pnpm run build
  • cargo test --manifest-path desktop/src-tauri/Cargo.toml
  • cd desktop && pnpm exec playwright test tests/e2e/team-management-screenshots.spec.ts --project=smoke

klopez4212 added a commit that referenced this pull request Jun 19, 2026
@klopez4212

Copy link
Copy Markdown
Contributor Author

🤖 ## Screenshots

Agents

Cards use the cleaned initials/avatar treatment with the New Agent card at the end.

00-agents-section

Teams

Team cards show the stacked member treatment and modal/menu states.

01-teams-section

02-team-card-menu

03-directory-team-card

04-directory-team-menu

05-symlinked-team

06-install-from-directory-modal

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b414b6279b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/useManagedAgentActions.ts Outdated
Comment thread desktop/src/features/agents/ui/TeamsSection.tsx Outdated
Comment thread desktop/src/features/agents/ui/usePersonaActions.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 483dab4164

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/profile/ui/UserProfilePanel.tsx Outdated
Comment thread desktop/src/features/profile/ui/UserProfilePanel.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e0cfd5861

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/PersonaDialog.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6de73be5bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/profile/ui/UserProfilePanel.tsx
Comment thread desktop/src-tauri/src/managed_agents/persona_card.rs Outdated
@klopez4212 klopez4212 force-pushed the kennylopez-agents-panel branch from 6de73be to ec0d366 Compare June 19, 2026 11:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec0d366fbd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/channelAgents.ts
Comment thread desktop/src/features/profile/ui/UserProfilePanelDeletion.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b952a4b753

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/UnifiedAgentsSection.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f4e08abf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/PersonaDialog.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e0740bf6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/profile/ui/UserProfilePanel.tsx
Comment thread desktop/src-tauri/src/commands/agents.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b9acb88e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/PersonaDialog.tsx Outdated
# Conflicts:
#	desktop/src/features/agents/ui/AgentsScreen.tsx
#	desktop/src/features/agents/ui/AgentsView.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2a79d7cc6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/PersonaDialog.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 458e2669bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src-tauri/src/commands/agent_models.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

let (_prov, id) = buzz_persona_pkg::persona::split_model(s);
Some(id.to_owned())

P2 Badge Preserve providers from Markdown model prefixes

For newly accepted plain/Goose Markdown personas whose frontmatter uses model: anthropic:claude..., this split extracts the provider but discards it, and the preview is returned with provider: None; the create flow then persists only the stripped model while spawn-time env generation only sets provider vars from PersonaRecord.provider. In that import scenario the agent starts under the runtime's default provider instead of the provider encoded in the card.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/profile/ui/UserProfilePanel.tsx
@klopez4212

Copy link
Copy Markdown
Contributor Author

🤖 Addressed the Codex review-body note “Preserve providers from Markdown model prefixes” in 5c9b795: strict and lenient Markdown persona imports now split provider:model into a preserved provider plus the stripped model id, with Rust parser coverage for both paths. This note was posted as a review body rather than a resolvable review thread, so there was no thread to resolve.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c9b7958bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/BatchImportDialog.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7fd8fce25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/PersonaDialog.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b733c33dac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<UserProfileAgentActions
isPending={isAgentActionPending}
managedAgent={managedAgent}
onDelete={persona ? handleDeletePersona : handleDeleteAgent}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route instance deletes to agent deletion

When the panel is opened for a specific persona-backed managed agent (including entries under “Additional agent instances”), persona is always resolved from managedAgent.personaId, so the row labeled “Delete agent” calls handleDeletePersona instead of handleDeleteAgent. In that scenario a user trying to delete one agent instance deletes/deactivates the persona and all managed-agent records for that persona; keep managed-agent profile deletes on the instance deletion path and expose persona deletion separately.

Useful? React with 👍 / 👎.

diagnosticsFields={diagnosticsFields}
diagnosticsSummary={diagnosticsSummary}
modelLabel={modelLabel}
onOpenAgentInfo={() => setView("info")}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Accept new profile subviews in channel URLs

These new subview links work in the Agents screen, but profiles opened from a channel are controlled by useChannelPanelHistoryState, whose asProfilePanelView still coerces every profileView except memories and channels back to summary. Clicking Agent info/settings/model/diagnostics/instructions in that context writes the new value to the URL and immediately renders the summary again, making the new panels unreachable from channel profiles; update the channel URL parser with the expanded ProfilePanelView union.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant