Fix SSH polling, disable Ignition+FCOS for now#281
Merged
Conversation
cgwalters
force-pushed
the
ignition-flakes
branch
from
9812d5a to
dfd232e
Compare
Collaborator
|
Need to fix this |
The libvirt SSH path had its own hand-rolled retry loop inside connect_ssh() (60s timeout, 1s poll), while the ephemeral path cleanly uses the shared wait_for_readiness() utility. Worse, wait_for_ssh_ready() called run_ssh_impl() which hit the connect_ssh() retry, creating a double-retry: each "attempt" in the outer 180s loop took ~60s, yielding only 3 effective iterations instead of ~36. Unify on the same pattern the ephemeral path uses: - Extract verify_domain_running() and prepare_ssh_session() helpers so setup (domain check, config extraction, temp key) is done once. - Replace connect_ssh()'s retry loop with wait_for_readiness() inside run_ssh_impl(), matching run_ephemeral_ssh::wait_for_ssh_ready(). - Rename connect_ssh to exec_ssh_session (it no longer retries). - Simplify wait_for_ssh_ready() in run.rs to do setup once then poll with just the SSH command, instead of reconstructing everything per attempt. Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
FCOS installed via bootc install drops into emergency mode because the partition layout (BIOS boot + EFI + root) lacks the "boot"-labeled partition that coreos-boot-mount-generator expects. The 90-second device wait for /dev/disk/by-label/boot times out, then SSHD never starts and the root account is locked. Ignition itself is also skipped — bootc install marks the disk as provisioned, so FCOS treats every boot as "subsequent." An analogous fix landed for the ephemeral/virtiofs case in coreos/fedora-coreos-config#3859 but the bootc-install-to-disk case is not yet handled upstream. Disable the test registration (keeping the code) until the upstream generator is fixed. The other ignition tests (invalid path, unsupported image) still run and pass. Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
ignition-flakes
branch
from
dfd232e to
ef1500b
Compare
gursewak1997
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.