Filter out BLS entries not managed by bootc#2243
Conversation
Signed-off-by: Dudecake <ckoomen@ckoomen.eu>
Signed-off-by: Dudecake <ckoomen@ckoomen.eu>
dba7de3 to
9ade58e
Compare
| pub(crate) const UKI_NAME_PREFIX: &str = TYPE1_BOOT_DIR_PREFIX; | ||
|
|
||
| /// The prefix for BLS file entries | ||
| pub(crate) const BLS_ENTRY_PREFIX: &str = "bootc_"; |
There was a problem hiding this comment.
We have TYPE1_BOOT_DIR_PREFIX for this
There was a problem hiding this comment.
I didn't want to change that from bootc_composefs- -> bootc_ as it's used in other places. The format the BLS entry seems to follow is bootc_${ID}-${verity}-${index}.conf, though maybe I've misunderstood what the BLS entry is...
Sad face. That makes this pretty useless as installing to a populated ESP works without issue, only Would the caller of |
yes, and these need special treatment for updates/switches. Also, we need to make sure these appear last in the boot entries list etc etc. There are a few more cases that need to be handled |
Fixes #2228
The cases that the tests in the last commit check cannot occur anymore because of the changes in
get_sorted_type1_boot_entries_helper. If they're unneeded, I can drop the commit.