Make incident status optional in create validation

[jbrooksuk]

Problem

The nightly test run started failing intermittently (run 27315738081) with:

FAILED  Tests\Unit\Actions\Incident\CreateIncidentTest  ValidationException
The status field is required.

at the two tests that create an incident without a status (CreateIncidentTest.php:17 and :99). It reproduced only under the full parallel suite, not in isolation.

Root cause

CreateIncidentRequestData::rules() marked status as required, but status is optional everywhere else:

• the constructor defaults it to null (?IncidentStatusEnum $status = null)
• the incidents.status column is nullable (2023_08_21_..._make_incident_columns_nullable)
• UpdateIncidentRequestData treats it as optional
• a null status is a valid, supported state (rendered as "reported")

The workbench config sets validation_strategy: Always, so from() validates on every call, and spatie/laravel-data's structure cache is shared across the 10 parallel test workers via the file store. Once the status => required rule was resolved/cached from a status-bearing payload, it could be applied to the status-less unit-test payloads — surfacing the failure intermittently depending on worker assignment and ordering.

Fix

Make status nullable instead of required, aligning the create rules with the constructor, the column, and the update request. Status-less incident creation now validates deterministically.

Verification

Full suite green in parallel on both dependency sets:

• --prefer-lowest (spatie/laravel-data 4.11): 408 passed
• --prefer-stable (spatie/laravel-data 4.23): 408 passed

🤖 Generated with Claude Code