Feat/embed filepicker#249
Open
diocas wants to merge 7 commits into
Open
Conversation
To allow them to be downloaded without the user token.
Allows embeding the UI and delegating the attach action (via a post message). Users have to select files, and the application will then ask cernbox to return the list of files selected with the respective download urls.
Since folders cannot be downloaded, it prevents their selection to make it clear to users.
…on embed mode. Update tests to ensure correct message posting behavior and add checks for file selection in embed mode.
Gerry-Cern
approved these changes
Jun 9, 2026
Gerry-Cern
left a comment
Gerry-Cern
left a comment
There was a problem hiding this comment.
LGTM, fixed some small bugs and added some unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New embedded mode to replace the current file picker that we expose to Indico and CodiMD.
Made changes to try to be as close as the current implementation but still needs to be tested.