Skip to content

fix(shared): Added support for global navigator check to isValidBrowser#8827

Open
royanger wants to merge 2 commits into
mainfrom
roy/user-5475-shared-navigator-fallback-service-worker
Open

fix(shared): Added support for global navigator check to isValidBrowser#8827
royanger wants to merge 2 commits into
mainfrom
roy/user-5475-shared-navigator-fallback-service-worker

Conversation

@royanger

@royanger royanger commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Fixed browser connectivity detection for service worker environments, ensuring proper fallback mechanisms when standard browser APIs are unavailable. This prevents misleading offline errors and improves token retrieval reliability in extension contexts.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jun 11, 2026 5:31am
swingset Ready Ready Preview, Comment Jun 11, 2026 5:31am

Request Review

@changeset-bot

changeset-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d7130c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@clerk/shared Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/expo-passkeys Patch
@clerk/expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding support for global navigator checks in isValidBrowser and related functions.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@royanger royanger changed the title fix: Added support for global navigator check to isValidBrowser fix(shared): Added support for global navigator check to isValidBrowser Jun 11, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jun 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8827

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8827

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8827

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8827

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8827

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8827

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8827

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8827

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8827

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8827

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8827

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8827

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8827

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8827

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8827

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8827

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8827

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8827

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8827

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8827

commit: d7130c8

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-11T05:32:16.631Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on d7130c8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant