[LCHIB-750] Fix robot subset to use file-level suite name as classname for nested suites#1320
Merged
Merged
Conversation
…sname for nested suites Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When Robot Framework tests are organized in subdirectories (e.g.
tests/robot/api/*.robot), theparse_funcinrobot.pywas assigning the directory-level suite name (e.g.Api,Integration) as theclassnameinstead of the file-level suite name (e.g.Auth,Comments).This caused the server-side
RobotFrameworkResolverto fail because it tries to matchApi→api.robot, which doesn't exist. The actual files areauth.robot,comments.robot, etc.What
Added a
find_leaf_suiteshelper insideparse_functhat recursively traverses the suite hierarchy until it reaches leaf suites (suites that contain<test>elements directly but no child<suite>elements). Only leaf suites — which correspond to individual.robotfiles — are passed toparse_suite, ensuring the correct file-level suite name is used asclassname.Before:
After:
Also updated test fixtures (
output.xml,record_test_result.json) to cover both flat (2-level) and nested (3-level) suite structures. Thefind_leaf_suiteshelper is recursive and handles any depth (2, 3, 4+ levels).Please Review Here
test_record_test_legacywas already failing onv1before this change (token/org mismatch in mock setup) — not related to this fix.