feat(AIENG-359): Add GitFileTest to validate text file detection logic#1325
Merged
Conversation
Konboi
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way the
GitFile.isText()method determines whether a file is text or binary, replacing a character-based stream approach with direct UTF-8 decoding. It also adds a new unit test class to ensure correctness, and updates the test suite to include these tests.Refactoring and bug fixes:
GitFile.isText()to use a UTF-8 decoder with strict error handling (CodingErrorAction.REPORT) on the file's bytes, instead of reading the file as characters. This provides more accurate detection of binary files and improves performance. [1] [2]Testing improvements:
GitFileTestto verify the behavior ofGitFile.isText()for text files, binary files, and files with multi-byte UTF-8 content.AllTestssuite to include the newGitFileTestclass, ensuring these tests are run automatically.