Skip to content

CI: check launchable/jar/exe_deploy.jar is up to date when src/ Java files change#1326

Merged
Konboi merged 1 commit into
v1from
check-java-build
Jun 16, 2026
Merged

CI: check launchable/jar/exe_deploy.jar is up to date when src/ Java files change#1326
Konboi merged 1 commit into
v1from
check-java-build

Conversation

@Konboi

@Konboi Konboi commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Why

When Java source files under src/ are updated, build-java.sh must be run to regenerate and copy exe_deploy.jar to launchable/jar/exe_deploy.jar. This step is easy to forget, and there was no CI check to catch it.

What

Added a new step to the bazel-test.yml workflow that:

  • Runs only when src/ Java files change (already handled by the existing paths trigger)
  • Builds the jar with Bazel
  • Compares the built jar against launchable/jar/exe_deploy.jar using diff
  • Fails with a clear error message if they differ, prompting the developer to run build-java.sh

Please Review Here

  • The check reuses the already-built jar from the previous bazel test //... step via Bazel's cache, so the extra bazel build call should be fast.
  • This PR targets v1. A separate PR will be needed for main (where the copy destination is smart_tests/jar/exe_deploy.jar instead).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Konboi Konboi force-pushed the check-java-build branch from 564d09f to 52a28dd Compare June 16, 2026 04:29
@Konboi

Konboi commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@Konboi Konboi merged commit 946ed66 into v1 Jun 16, 2026
28 checks passed
@Konboi Konboi deleted the check-java-build branch June 16, 2026 05:16
This was referenced Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants