Performance fixes for permission queries#5172
Open
philippthun wants to merge 1 commit into
Open
Conversation
PR cloudfoundry#5157 introduced authorized_space_ids_subquery and authorized_org_ids_subquery. These methods avoid unnecessary subplans on the spaces / organizations tables on every permission lookup and are now also used by: - Permissions#readable_security_group_guids_query - Permissions#readable_space_quota_guids - Permissions#is_org_manager? - Membership#authorized_space_guids_subquery - Membership#authorized_org_guids_subquery - Service-credential-binding fetchers - Service-offering / service-plan list fetchers The service-offering / service-plan list fetchers now take both *_ids_query and *_query; the id-query feeds the always-executed permission filter, the full query is consulted only on guid-filtered requests. Also removes the now-dead 'membership' helper from v3/application_controller.rb (no V3 controller calls it after cloudfoundry#5094).
philippthun
force-pushed
the
extend-perf-fixes
branch
from
4e1272e to
408d53b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5157 introduced
authorized_space_ids_subqueryandauthorized_org_ids_subquery. These methods avoid unnecessary subplans on the spaces / organizations tables on every permission lookup and are now also used by:Permissions#readable_security_group_guids_queryPermissions#readable_space_quota_guidsPermissions#is_org_manager?Membership#authorized_space_guids_subqueryMembership#authorized_org_guids_subqueryService-credential-binding fetchersService-offering / service-plan list fetchersThe service-offering / service-plan list fetchers now take both
*_ids_queryand*_query; the id-query feeds the always-executed permission filter, the full query is consulted only on guid-filtered requests.Also removes the now-dead
membershiphelper from v3/application_controller.rb (no V3 controller calls it after #5094).I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests