fix(tests): correct SapMachine and Tomcat version assertion strings#1315
Merged
ramonskie merged 2 commits intoJun 10, 2026
Merged
Conversation
cloudfoundry#1288 BaseJRE refactor renamed the install log from "Installing SAP Machine" to "Installing SapMachine"; four assertions in tomcat_test.go and java_main_test.go were missed.
Commit 90abbc2 changed the log format from "Installed Tomcat version %s" to "Installed Tomcat (%s)" but did not update the integration test assertions that matched "Tomcat 9" and "Tomcat 10". Those substrings no longer appear in the output, causing all JRE-selection Tomcat tests to fail.
ramonskie
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Installing SAP Machine→Installing SapMachineintomcat_test.goandjava_main_test.go(missed in refactor: extract BaseJRE to eliminate duplication across standard JRE providers #1288)Tomcat 9/Tomcat 10→Installed Tomcat (9./Installed Tomcat (10.— log format changed in reduce install framework logging during startup #1230 fromInstalled Tomcat version %stoInstalled Tomcat (%s)but assertions were not updatedNo functional code changes — test assertions only.