Skip to content

Add disk read-only healthcheck to rep#88

Open
geofffranks wants to merge 1 commit into
mainfrom
TNZ-106712-disk-readonly-healthcheck
Open

Add disk read-only healthcheck to rep#88
geofffranks wants to merge 1 commit into
mainfrom
TNZ-106712-disk-readonly-healthcheck

Conversation

@geofffranks

Copy link
Copy Markdown
Contributor

Summary

Introduces a diskcheck package with platform-specific filesystem read-only detection (Linux/macOS/Windows stubs), a Runner that periodically checks configured paths and signals the process unhealthy on initial failure, and wires it into rep's ordered grouper. Adds DiskHealthCheckPaths and DiskHealthCheckInterval config fields. Windows implementation is deferred.

Backward Compatibility

Breaking Change? no

Introduces a diskcheck package with platform-specific filesystem read-only
detection (Linux/macOS/Windows stubs), a Runner that periodically checks
configured paths and signals the process unhealthy on initial failure, and
wires it into rep's ordered grouper. Adds DiskHealthCheckPaths and
DiskHealthCheckInterval config fields. Windows implementation is deferred.

Co-authored-by: Cursor <cursoragent@cursor.com>
SupportedProviders: []string{"provider1", "provider2"},
Zone: "test-zone",
ReportInterval: durationjson.Duration(2 * time.Minute),
LayeringMode: "single-layer",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing go fmt.

Comment thread diskcheck/runner.go
checkPath func(string) (bool, error),
) *Runner {
if failureThreshold <= 0 {
failureThreshold = 1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this failurethreshold be same value as specified in main.go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants