Skip to content

Fix typos in documentation#32

Merged
clue merged 1 commit into
clue:1.xfrom
yadaiio:typos
Nov 13, 2023
Merged

Fix typos in documentation#32
clue merged 1 commit into
clue:1.xfrom
yadaiio:typos

Conversation

@yadaiio

@yadaiio yadaiio commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.

Builds on top of #10 and clue/reactphp-redis#146.

@SimonFrings SimonFrings added the documentation Improvements or additions to documentation label Nov 2, 2023
@SimonFrings

Copy link
Copy Markdown
Contributor

Thanks for your contribution 👍

Pull request itself looks good. The test matrix is currently not running through because of an outdated CI workflow, so we need to make a few adjustments before we can merge this. The changes will be similar to the work done in reactphp/socket#299, reactphp/socket#300 and reactphp/socket#310.

Is this something you can look into?

@SimonFrings

Copy link
Copy Markdown
Contributor

@yadaiio I just created a pull request to update the test suite so that your checks should be green after #33 is merged.

@SimonFrings SimonFrings added this to the v1.3.0 milestone Nov 9, 2023
@yadaiio

yadaiio commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

Thanks to @SimonFrings, I was able to rebase my branch after implementing the new feature described in #33. Fortunately, there were no conflicts, and all tests passed successfully.

This PR is now ready to be reviewed by @clue and @SimonFrings. 🎉

@yadaiio

yadaiio commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for your contribution 👍

Pull request itself looks good. The test matrix is currently not running through because of an outdated CI workflow, so we need to make a few adjustments before we can merge this. The changes will be similar to the work done in reactphp/socket#299, reactphp/socket#300 and reactphp/socket#310.

Is this something you can look into?

Really thankful for our workshop. I feel confident that I will be able to work on this independently in the future. 🥳

@SimonFrings SimonFrings left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for rebasing, these changes look good to me 👍

@clue clue left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for looking into this, changes LGTM! :shipit:

@clue clue merged commit 59c99f1 into clue:1.x Nov 13, 2023
@yadaiio yadaiio mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants