fix(compute_worker): make submission lifecycle idempotent against bro…#2434
Draft
AybH26 wants to merge 1 commit into
Draft
fix(compute_worker): make submission lifecycle idempotent against bro…#2434AybH26 wants to merge 1 commit into
AybH26 wants to merge 1 commit into
Conversation
89ed741 to
42d9950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ mention of reviewers
A brief description of the purpose of the changes contained in this PR
compute_workerusestask_acks_late = True, so any worker that dies before acking causes RabbitMQ to redeliver the run payload. The redelivered worker used to re-execute the full lifecycle, causing:scoring_worker_hostnameoverwritten by the second workerstatusflipped backwards throughRunning → Scoring → Finishedagainupload_submission_scoresinserted duplicateSubmissionScorerows, crashingcalculate_scores()withMultipleObjectsReturnedThis PR makes the lifecycle idempotent on both sides (worker short-circuits + server refuses terminal mutations). Defense-in-depth, Stripe-style.
Issues this PR resolves
Closes #2433
A checklist for hand testing
POST /api/submissions/<id>/upload_submission_scores/with new hostname & scoresworker_attempt_countincrements;statusstays terminalMultipleObjectsReturnedexception in logsSubmission.objects.get(pk=26).worker_attempt_count >= 2Any relevant files for testing
Run._fetch_submission_state()+run_wrapper()short-circuitworker_stateendpoint,check_object_permissionsguard,upload_submission_scoresupsertSubmission.worker_attempt_countfieldChecklist